linux-kernel - Re: [PATCH memory-model 6/7] tools/memory-model: Switch to softcoded herd7 tags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <756aed25-f4de-4c2f-b6e8-5bf67c0fde69@huaweicloud.com>
Date: Tue, 25 Feb 2025 08:40:43 +0100
From: Hernan Ponce de Leon <hernan.poncedeleon@...weicloud.com>
To: Akira Yokosawa <akiyks@...il.com>, "Paul E. McKenney"
 <paulmck@...nel.org>, linux-kernel@...r.kernel.org,
 linux-arch@...r.kernel.org, lkmm@...ts.linux.dev, kernel-team@...a.com,
 mingo@...nel.org
Cc: stern@...land.harvard.edu, parri.andrea@...il.com, will@...nel.org,
 peterz@...radead.org, boqun.feng@...il.com, npiggin@...il.com,
 dhowells@...hat.com, j.alglave@....ac.uk, luc.maranget@...ia.fr,
 Jonas Oberhauser <jonas.oberhauser@...weicloud.com>
Subject: Re: [PATCH memory-model 6/7] tools/memory-model: Switch to softcoded
 herd7 tags

On 2/25/2025 5:24 AM, Akira Yokosawa wrote:
> On Thu, 20 Feb 2025 08:14:02 -0800, Paul E. McKenney wrote:
>> From: Jonas Oberhauser <jonas.oberhauser@...weicloud.com>
>>
>> A new version of herd7 provides a -lkmmv2 switch which overrides the old herd7
>> behavior of simply ignoring any softcoded tags in the .def and .bell files. We
>> port LKMM to this version of herd7 by providing the switch in linux-kernel.cfg
>> and reporting an error if the LKMM is used without this switch.
>>
>> To preserve the semantics of LKMM, we also softcode the Noreturn tag on atomic
>> RMW which do not return a value and define atomic_add_unless with an Mb tag in
>> linux-kernel.def.
>>
>> We update the herd-representation.txt accordingly and clarify some of the
>> resulting combinations.
>>
> 
> Having failed to hear from Jonas or Hernan in response to my question at:
> 
>      https://lore.kernel.org/lkmm/ec97f28e-31ad-4a45-ac87-fab91e27d4ee@gmail.com/

Sorry Akira, I lost track of the thread and forgot to answer.

> 
> , let me guess.  Past contributions strongly suggest that Hernan looks after
> herd7 changes and Jonas takes care of LKMM side of changes.

Yes, this is correct.

Hernan

> 
> So my suggestion is to add a Co-developed-by tag of Hernan here:
> 
> Co-developed-by: Hernan Ponce de Leon <hernan.poncedeleon@...weicloud.com>
>> Signed-off-by: Hernan Ponce de Leon <hernan.poncedeleon@...weicloud.com>
>> Signed-off-by: Jonas Oberhauser <jonas.oberhauser@...weicloud.com>
>> Signed-off-by: Paul E. McKenney <paulmck@...nel.org>
>> Reviewed-by: Boqun Feng <boqun.feng@...il.com>
>> Tested-by: Boqun Feng <boqun.feng@...il.com>
> 
> , and let me add a Tested-by:
> 
> Tested-by: Akira Yokosawa <akiyks@...il.com> # herdtools7.7.58
> 
>          Thanks, Akira
> 
>> ---
>>   .../Documentation/herd-representation.txt     | 27 ++++++++++---------
>>   tools/memory-model/README                     |  2 +-
>>   tools/memory-model/linux-kernel.bell          |  3 +++
>>   tools/memory-model/linux-kernel.cfg           |  1 +
>>   tools/memory-model/linux-kernel.def           | 18 +++++++------
>>   5 files changed, 30 insertions(+), 21 deletions(-)