linux-kernel - Re: [PATCH v3 09/12] media: cx231xx: Remove vidioc_s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <34f42e07-b543-4cf7-b0a1-cf72eba70786@xs4all.nl>
Date: Tue, 25 Feb 2025 09:19:08 +0100
From: Hans Verkuil <hverkuil@...all.nl>
To: Ricardo Ribalda <ribalda@...omium.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Mike Isely <isely@...ox.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Hans de Goede <hdegoede@...hat.com>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Andy Shevchenko <andy@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-staging@...ts.linux.dev
Subject: Re: [PATCH v3 09/12] media: cx231xx: Remove vidioc_s_ctrl callback

On 23/02/2025 19:58, Ricardo Ribalda wrote:
> The driver has been converted to the control framework in the past:
> commit 88b6ffedd901 ("[media] cx231xx-417: convert to the control
> framework").
> 
> This function is never called, the core will only use the control
> framework instead.
> 
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>

Tested-by: Hans Verkuil <hverkuil@...all.nl>

Regards,

	Hans

> ---
>  drivers/media/usb/cx231xx/cx231xx-417.c | 15 ---------------
>  1 file changed, 15 deletions(-)
> 
> diff --git a/drivers/media/usb/cx231xx/cx231xx-417.c b/drivers/media/usb/cx231xx/cx231xx-417.c
> index a4a9781328c5..5a4b0f96cca2 100644
> --- a/drivers/media/usb/cx231xx/cx231xx-417.c
> +++ b/drivers/media/usb/cx231xx/cx231xx-417.c
> @@ -1538,20 +1538,6 @@ static int vidioc_s_std(struct file *file, void *priv, v4l2_std_id id)
>  	return 0;
>  }
>  
> -static int vidioc_s_ctrl(struct file *file, void *priv,
> -				struct v4l2_control *ctl)
> -{
> -	struct cx231xx *dev = video_drvdata(file);
> -	struct v4l2_subdev *sd;
> -
> -	dprintk(3, "enter vidioc_s_ctrl()\n");
> -	/* Update the A/V core */
> -	v4l2_device_for_each_subdev(sd, &dev->v4l2_dev)
> -		v4l2_s_ctrl(NULL, sd->ctrl_handler, ctl);
> -	dprintk(3, "exit vidioc_s_ctrl()\n");
> -	return 0;
> -}
> -
>  static int vidioc_enum_fmt_vid_cap(struct file *file, void  *priv,
>  					struct v4l2_fmtdesc *f)
>  {
> @@ -1627,7 +1613,6 @@ static const struct v4l2_ioctl_ops mpeg_ioctl_ops = {
>  	.vidioc_enum_input	 = cx231xx_enum_input,
>  	.vidioc_g_input		 = cx231xx_g_input,
>  	.vidioc_s_input		 = cx231xx_s_input,
> -	.vidioc_s_ctrl		 = vidioc_s_ctrl,
>  	.vidioc_g_pixelaspect	 = vidioc_g_pixelaspect,
>  	.vidioc_g_selection	 = vidioc_g_selection,
>  	.vidioc_querycap	 = cx231xx_querycap,
>