linux-kernel - Re: [PATCH] reboot: hide unused hw_protection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z70WFl8rOrZ9XCWV@google.com>
Date: Tue, 25 Feb 2025 01:00:06 +0000
From: Tzung-Bi Shih <tzungbi@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Ahmad Fatoum <a.fatoum@...gutronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Arnd Bergmann <arnd@...db.de>,
	Joel Granados <joel.granados@...nel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] reboot: hide unused hw_protection_attr

On Mon, Feb 24, 2025 at 03:16:09PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The reference to hw_protection_attr is inside of an #ifdef block,
> but the definition is not:
> 
> kernel/reboot.c:1092:30: error: unused variable 'hw_protection_attr' [-Werror,-Wunused-variable]
>  1092 | static struct kobj_attribute hw_protection_attr = __ATTR_RW(hw_protection);
>       |                              ^~~~~~~~~~~~~~~~~~
> 
> Add another #ifdef to match the first.
> 
> Fixes: 6f0ec17b2d82 ("reboot: add support for configuring emergency hardware protection action")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Tzung-Bi Shih <tzungbi@...nel.org>