linux-kernel - Re: [PATCH v3] HSI: ssi_protocol: Fix use after free vulnerability in ssi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <srkkyfb7lm4ywuro6vunaunv6q6sf4a3epyhggfzno4rk4v7wx@cgdxyuofk47m>
Date: Tue, 25 Feb 2025 02:08:48 +0100
From: Sebastian Reichel <sre@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Kaixin Wang <kxwang23@...udan.edu.cn>, rdunlap@...radead.org, 
	linux-kernel@...r.kernel.org, 21210240012@...udan.edu.cn, 21302010073@...udan.edu.cn
Subject: Re: [PATCH v3] HSI: ssi_protocol: Fix use after free vulnerability
 in ssi_protocol Driver Due to Race Condition

Hi,

On Mon, Feb 24, 2025 at 12:59:49PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 24, 2025 at 11:23:06AM +0800, Kaixin Wang wrote:
> > At 2024-09-18 20:07:50, "Kaixin Wang" <kxwang23@...udan.edu.cn> wrote:
> 
> > >In the ssi_protocol_probe() function, &ssi->work is bound with
> > >ssip_xmit_work(), In ssip_pn_setup(), the ssip_pn_xmit() function
> > >within the ssip_pn_ops structure is capable of starting the
> > >work.
> > >
> > >If we remove the module which will call ssi_protocol_remove()
> > >to make a cleanup, it will free ssi through kfree(ssi),
> > >while the work mentioned above will be used. The sequence
> > >of operations that may lead to a UAF bug is as follows:
> > >
> > >CPU0                                    CPU1
> > >
> > >                        | ssip_xmit_work
> > >ssi_protocol_remove     |
> > >kfree(ssi);             |
> > >                        | struct hsi_client *cl = ssi->cl;
> > >                        | // use ssi
> > >
> > >Fix it by ensuring that the work is canceled before proceeding
> > >with the cleanup in ssi_protocol_remove().
> 
> ...
> 
> > Hi, I noticed that there are no relevant replies to this patch that I sent
> > several months ago. Is it missed?
> 
> Seems like fell into cracks...

Indeed, but queued to hsi for-next now.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)