linux-kernel - Re: [PATCH v3 1/2] mm: slub: Print the broken data before restoring slub.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250225011154.GB2345951@tiffany>
Date: Tue, 25 Feb 2025 10:11:54 +0900
From: Hyesoo Yu <hyesoo.yu@...sung.com>
To: "Christoph Lameter (Ampere)" <cl@...two.org>
Cc: janghyuck.kim@...sung.com, vbabka@...e.cz, Pekka Enberg
	<penberg@...nel.org>, David Rientjes <rientjes@...gle.com>, Joonsoo Kim
	<iamjoonsoo.kim@....com>, Andrew Morton <akpm@...ux-foundation.org>, Roman
	Gushchin <roman.gushchin@...ux.dev>, Hyeonggon Yoo <42.hyeyoo@...il.com>,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] mm: slub: Print the broken data before restoring
 slub.

On Mon, Feb 24, 2025 at 09:24:42AM -0800, Christoph Lameter (Ampere) wrote:
> On Thu, 20 Feb 2025, Hyesoo Yu wrote:
> 
> > @@ -1396,11 +1400,6 @@ static int check_object(struct kmem_cache *s, struct slab *slab,
> >  		ret = 0;
> >  	}
> >
> > -	if (!ret && !slab_in_kunit_test()) {
> 
> 
> > -		print_trailer(s, slab, object);
> > -		add_taint(TAINT_BAD_PAGE, LOCKDEP_NOW_UNRELIABLE);
> 
> No tainting and printing of the trailer anymore?
> 

If there is an error before on check_object, the check_bytes_and_report
calls object_err that calls print_trailer and add_traint.

Thanks,
Regards.