linux-kernel - Re: [PATCH v2 4/6] sysctl: Fixes scsi_logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1y0xubz40.fsf@ca-mkp.ca.oracle.com>
Date: Mon, 24 Feb 2025 20:20:45 -0500
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: nicolas.bouchinet@...p-os.org
Cc: linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org,
        linux-scsi@...r.kernel.org, codalist@...a.cs.cmu.edu,
        linux-nfs@...r.kernel.org,
        Nicolas Bouchinet
 <nicolas.bouchinet@....gouv.fr>,
        Joel Granados <j.granados@...sung.com>,
        Clemens Ladisch <clemens@...isch.de>, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jason Gunthorpe
 <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>,
        "James E.J.
 Bottomley" <James.Bottomley@...senPartnership.com>,
        "Martin K. Petersen"
 <martin.petersen@...cle.com>,
        Jan Harkes <jaharkes@...cmu.edu>,
        Chuck
 Lever <chuck.lever@...cle.com>,
        Jeff Layton <jlayton@...nel.org>, Neil
 Brown <neilb@...e.de>,
        Olga Kornievskaia <okorniev@...hat.com>, Dai Ngo
 <Dai.Ngo@...cle.com>,
        Tom Talpey <tom@...pey.com>, Trond Myklebust
 <trondmy@...nel.org>,
        Anna Schumaker <anna@...nel.org>,
        Bart Van Assche
 <bvanassche@....org>,
        Zhu Yanjun <yanjun.zhu@...ux.dev>, Al Viro
 <viro@...iv.linux.org.uk>,
        Christian Brauner <brauner@...nel.org>
Subject: Re: [PATCH v2 4/6] sysctl: Fixes scsi_logging_level bounds


Hi Nicolas!

> --- a/drivers/scsi/scsi_sysctl.c
> +++ b/drivers/scsi/scsi_sysctl.c
> @@ -17,7 +17,9 @@ static const struct ctl_table scsi_table[] = {
>  	  .data		= &scsi_logging_level,
>  	  .maxlen	= sizeof(scsi_logging_level),
>  	  .mode		= 0644,
> -	  .proc_handler	= proc_dointvec },
> +	  .proc_handler	= proc_dointvec_minmax,
> +	  .extra1	= SYSCTL_ZERO,
> +	  .extra2	= SYSCTL_INT_MAX },

scsi_logging_level is a bitmask and should be unsigned.

-- 
Martin K. Petersen	Oracle Linux Engineering