linux-kernel - Re: [PATCH] ARM: dts: qcom: msm8960: add tsens

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <xgj6voxz7vf52tg2zslnj6wdih63vjrwqesgeuiqzopmjqhcr2@x54q5pxopvxu>
Date: Tue, 25 Feb 2025 11:56:14 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Rudraksha Gupta <guptarud@...il.com>
Cc: Bjorn Andersson <andersson@...nel.org>, 
	Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	wctrl <wctrl@...ton.me>
Subject: Re: [PATCH] ARM: dts: qcom: msm8960: add tsens

On Tue, Feb 25, 2025 at 01:19:44AM -0800, Rudraksha Gupta wrote:
> Copy tsens node from ap8064 and adjust some values
> 
> Co-developed-by: wctrl <wctrl@...ton.me>
> Signed-off-by: wctrl <wctrl@...ton.me>
> Signed-off-by: Rudraksha Gupta <guptarud@...il.com>
> ---
>  arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 62 +++++++++++++++++++++++++++++++-
>  1 file changed, 61 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
> index 865fe7cc39511d7cb9ec5c4b12100404f77e2989..167953605447bfaa0d33b0e41b581220f86c72e6 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
> @@ -52,6 +52,40 @@ memory@...00000 {
>  		reg = <0x80000000 0>;
>  	};
>  
> +	thermal-zones {
> +		cpu0-thermal {
> +			polling-delay-passive = <250>;
> +			polling-delay = <1000>;
> +
> +			thermal-sensors = <&tsens 0>;
> +			coefficients = <1199 0>;

Doesn't tsens driver read the slope and offset from the EEPROM?

> +
> +
> +			tsens_calib: calib@404 {
> +				reg = <0x404 0x10>;
> +			};
> +			tsens_backup: backup-calib@414 {
> +				reg = <0x414 0x10>;
> +			};

missing empty line between nodes


> +		};
> +
>  		msmgpio: pinctrl@...000 {
>  			compatible = "qcom,msm8960-pinctrl";
>  			gpio-controller;
> @@ -127,7 +175,7 @@ msmgpio: pinctrl@...000 {
>  		};
>  
>  		gcc: clock-controller@...000 {
> -			compatible = "qcom,gcc-msm8960";
> +			compatible = "qcom,gcc-msm8960", "syscon";
>  			#clock-cells = <1>;
>  			#reset-cells = <1>;
>  			reg = <0x900000 0x4000>;
> @@ -135,6 +183,18 @@ gcc: clock-controller@...000 {
>  				 <&pxo_board>,
>  				 <&lcc PLL4>;
>  			clock-names = "cxo", "pxo", "pll4";
> +
> +			tsens: thermal-sensor {
> +				compatible = "qcom,msm8960-tsens";
> +
> +				nvmem-cells = <&tsens_calib>, <&tsens_backup>;
> +				nvmem-cell-names = "calib", "calib_backup";
> +				interrupts = <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>;
> +				interrupt-names = "uplow";
> +
> +				#qcom,sensors = <5>;
> +				#thermal-sensor-cells = <1>;
> +			};
>  		};
>  
>  		lcc: clock-controller@...00000 {
> 
> ---
> base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
> change-id: 20250225-expressatt-tsens-06d46587a584
> 
> Best regards,
> -- 
> Rudraksha Gupta <guptarud@...il.com>
> 

-- 
With best wishes
Dmitry