linux-kernel - Re: [PATCH 1/5] arm64: dts: imx8-ss-hsio: Wire up DMA IRQ for PCIe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4962874.GXAFRqVoOG@steina-w>
Date: Tue, 25 Feb 2025 11:20:49 +0100
From: Alexander Stein <alexander.stein@...tq-group.com>
To: Frank Li <Frank.li@....com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, devicetree@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux@...tq-group.com
Subject: Re: [PATCH 1/5] arm64: dts: imx8-ss-hsio: Wire up DMA IRQ for PCIe

Hi Frank,

Am Montag, 24. Februar 2025, 18:49:01 CET schrieb Frank Li:
> On Wed, Jan 08, 2025 at 11:33:35AM -0500, Frank Li wrote:
> > On Wed, Jan 08, 2025 at 10:58:18AM +0100, Alexander Stein wrote:
> > > Hi Frank,
> > >
> > > Am Dienstag, 7. Januar 2025, 16:39:25 CET schrieb Frank Li:
> > > > On Tue, Jan 07, 2025 at 03:01:06PM +0100, Alexander Stein wrote:
> > > > > IRQ mapping is already present. Add the missing DMA interrupt.
> > > >
> > > > PCI host side have not use bridge's DMA yet although hardware support it.
> > >
> > > So this is a driver limitation, right? So IMHO the device description is
> > > independent from that and still correct, right?
> >
> > Yes, but dma register space may missed also. I suggest add later after
> > EP side support merged, which can verify informaiton is correct.
> >
> > Anyway, I don't block this change.
> 
> 
> Did you run DTB_CHECK? I found new warning was added
> 
> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dx-colibri-aster.dtb: pcie@...10000: interrupts: [[0, 102, 4], [0, 104, 4]] is too long
>         from schema $id: http://devicetree.org/schemas/pci/fsl,imx6q-pcie.yaml#
> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dx-colibri-aster.dtb: pcie@...10000: interrupt-names: ['msi', 'dma'] is too long
>         from schema $id: http://devicetree.org/schemas/pci/fsl,imx6q-pcie.yaml#
> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dx-colibri-eval-v3.dtb: pcie@...10000: interrupts: [[0, 102, 4], [0, 104, 4]] is too long
>         from schema $id: http://devicetree.org/schemas/pci/fsl,imx6q-pcie.yaml#
> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dx-colibri-eval-v3.dtb: pcie@...10000: interrupt-names: ['msi', 'dma'] is too long
>         from schema $id: http://devicetree.org/schemas/pci/fsl,imx6q-pcie.yaml#
> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dx-colibri-iris.dtb: pcie@...10000: interrupts: [[0, 102, 4], [0, 104, 4]] is too long
>         from schema $id: http://devicetree.org/schemas/pci/fsl,imx6q-pcie.yaml#
> /home/lizhi/source/linux-upstream-dts/arch/arm64/boot/dts/freescale/imx8dx-colibri-iris.dtb: pcie@...10000: interrupt-names: ['msi', 'dma'] is too long

I think I did, but I see the same warnings.
I've prepared a series which addresses schema and imx8qm dtsi.

Best regards
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/