linux-kernel - Re: [PATCH] rust: miscdevice: change how f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025022523-charbroil-overtime-4e68@gregkh>
Date: Tue, 25 Feb 2025 11:23:03 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Arnd Bergmann <arnd@...db.de>, Miguel Ojeda <ojeda@...nel.org>,
	Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Trevor Gross <tmgross@...ch.edu>, rust-for-linux@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: miscdevice: change how f_ops vtable is constructed

On Tue, Feb 25, 2025 at 11:10:17AM +0100, Alice Ryhl wrote:
> On Wed, Feb 19, 2025 at 4:58 PM Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> >
> > On Fri, Jan 17, 2025 at 02:22:32PM +0000, Alice Ryhl wrote:
> > > I was helping someone with writing a new Rust abstraction, and we were
> > > using the miscdevice abstraction as an example. While doing this, it
> > > became clear to me that the way I implemented the f_ops vtable is
> > > confusing to new Rust users, and that the approach used by the block
> > > abstractions is less confusing.
> > >
> > > Thus, update the miscdevice abstractions to use the same approach as
> > > rust/kernel/block/mq/operations.rs.
> > >
> > > Sorry about the large diff. This changes the indentation of a large
> > > amount of code.
> > >
> > > Signed-off-by: Alice Ryhl <aliceryhl@...gle.com>
> > > ---
> > >  rust/kernel/miscdevice.rs | 295 ++++++++++++++++++++++------------------------
> > >  1 file changed, 141 insertions(+), 154 deletions(-)
> >
> > This doesn't apply against a clean 6.14-rc2 tree, what is is made
> > against?
> 
> I will rebase.
> 
> Are there any other miscdevice commits that have landed this cycle
> that it might conflict with? If so, I can base it on your branch to
> avoid such conflicts.

Nope, I don't see any at the moment, or in my review queue, so it should
be fine.

thanks,

greg k-h