[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAD=FV=Uu+EvZzuFmCvq5qJ=FeBjmLTtfGT4Aq6QBSoH=Sen8PA@mail.gmail.com>
Date: Mon, 24 Feb 2025 17:40:58 -0800
From: Doug Anderson <dianders@...omium.org>
To: Damon Ding <damon.ding@...k-chips.com>
Cc: heiko@...ech.de, andy.yan@...k-chips.com, hjc@...k-chips.com,
robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
andrzej.hajda@...el.com, neil.armstrong@...aro.org, rfoss@...nel.org,
Laurent.pinchart@...asonboard.com, jonas@...boo.se, jernej.skrabec@...il.com,
dmitry.baryshkov@...aro.org, sebastian.reichel@...labora.com,
cristian.ciocaltea@...labora.com, boris.brezillon@...labora.com,
l.stach@...gutronix.de, dri-devel@...ts.freedesktop.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 05/15] drm/bridge: analogix_dp: Remove CONFIG_PM
related check in analogix_dp_bind()/analogix_dp_unbind()
Hi,
On Mon, Feb 24, 2025 at 12:14 AM Damon Ding <damon.ding@...k-chips.com> wrote:
>
> Remove the check related to CONFIG_PM in order to make the code more
> concise, as the CONFIG_PM should be a required option for many drivers.
>
> In addition, it is preferable to use devm_pm_runtime_enable() instead of
> manually invoking pm_runtime_enable() followed by pm_runtime_disable().
>
> Signed-off-by: Damon Ding <damon.ding@...k-chips.com>
> ---
> .../drm/bridge/analogix/analogix_dp_core.c | 30 ++++---------------
> 1 file changed, 6 insertions(+), 24 deletions(-)
If someone really has a reason to run this driver without CONFIG_PM
then happy to hear about it. Until then, I'd say this is fine and
matches what most drivers assume.
Suggested-by: Douglas Anderson <dianders@...omium.org>
Reviewed-by: Douglas Anderson <dianders@...omium.org>
Powered by blists - more mailing lists