linux-kernel - Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86 Macs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z72bZ3iURwhW5Pj1@smile.fi.intel.com>
Date: Tue, 25 Feb 2025 12:28:55 +0200
From: "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>
To: Thomas Zimmermann <tzimmermann@...e.de>
Cc: Aditya Garg <gargaditya08@...e.com>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"mripard@...nel.org" <mripard@...nel.org>,
	"airlied@...il.com" <airlied@...il.com>,
	"simona@...ll.ch" <simona@...ll.ch>,
	Kerem Karabay <kekrby@...il.com>,
	Atharva Tiwari <evepolonium@...il.com>,
	Aun-Ali Zaidi <admin@...eit.net>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v4 2/2] drm/tiny: add driver for Apple Touch Bars in x86
 Macs

On Tue, Feb 25, 2025 at 09:48:11AM +0100, Thomas Zimmermann wrote:
> Am 25.02.25 um 09:00 schrieb Aditya Garg:
> > > On 25 Feb 2025, at 1:22 PM, Thomas Zimmermann <tzimmermann@...e.de> wrote:
> > > > Am 24.02.25 um 14:40 schrieb Aditya Garg:

...

> > > > +struct appletbdrm_device {
> > > > +    struct device *dev;
> > > This field should go away, please. There's drm.dev, which contains the same address.
> > > 
> > > So seems to have remove the dmadev field instead, which you'll need for
> > > dma-buf sharing. Was that a misunderstanding from the last review?
> > Yeah that was a misunderstanding. I though you meant to remove dmadev.
> > > The rest of the driver looks good.
> > Maybe you missed the left over dev_err_probe left in this patch? I'll fix
> > them.
> 
> Sure.

But can you comment on my reply where I'm asking for a clarification how
drm_err() can be used on the physical device ->probe() to begin with?

> > > > +    unsigned int in_ep;
> > > > +    unsigned int out_ep;
> > > > +
> > > > +    unsigned int width;
> > > > +    unsigned int height;
> > > > +
> > > > +    struct drm_device drm;
> > > > +    struct drm_display_mode mode;
> > > > +    struct drm_connector connector;
> > > > +    struct drm_plane primary_plane;
> > > > +    struct drm_crtc crtc;
> > > > +    struct drm_encoder encoder;
> > > > +};

-- 
With Best Regards,
Andy Shevchenko