linux-kernel - Re: [PATCH v1 1/1] watchdog: nic7018

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z72iwgbvlYFCz5q0@smile.fi.intel.com>
Date: Tue, 25 Feb 2025 13:00:18 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Guenter Roeck <linux@...ck-us.net>, linux-watchdog@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>
Subject: Re: [PATCH v1 1/1] watchdog: nic7018_wdt: tidy up ACPI ID table

On Tue, Feb 25, 2025 at 11:58:04AM +0200, Andy Shevchenko wrote:
> Tidy up ACPI ID table:
> - drop ACPI_PTR() and hence replace acpi.h with mod_devicetable.h
> - remove explicit driver_data initializer
> - drop comma in the terminator entry
> 
> With that done, extend compile test coverage.

...

>  config NIC7018_WDT
>  	tristate "NIC7018 Watchdog"
> -	depends on X86 && ACPI
> +	depends on HAS_IOMEM

Oh, this should be HAS_IOPORT, compiling on X86 won't help to find this issue
:-)

> +	depends on ACPI || COMPILE_TEST
>  	select WATCHDOG_CORE

-- 
With Best Regards,
Andy Shevchenko