linux-kernel - Re: [PATCH v4 3/4] rust: configfs: add a sample demonstrating configfs usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <9E46FCD7-E913-43DF-91F7-417EF41A35B7@collabora.com>
Date: Tue, 25 Feb 2025 07:58:56 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Andreas Hindborg <a.hindborg@...nel.org>
Cc: Danilo Krummrich <dakr@...nel.org>,
 Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <benno.lossin@...ton.me>,
 Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>,
 Joel Becker <jlbec@...lplan.org>,
 Christoph Hellwig <hch@....de>,
 Peter Zijlstra <peterz@...radead.org>,
 Ingo Molnar <mingo@...hat.com>,
 Will Deacon <will@...nel.org>,
 Waiman Long <longman@...hat.com>,
 Fiona Behrens <me@...enk.dev>,
 Charalampos Mitrodimas <charmitro@...teo.net>,
 rust-for-linux@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 3/4] rust: configfs: add a sample demonstrating
 configfs usage


>> 
>> As I said in the previous patch, this macro is a bit complex. Is there anything more you can do with it?
>> 
>> If so, it better be in this driver, because I hardly think anybody will go through the source code itself
>> to figure out. My 2c.
> 
> I can add some inline comments on the usage here. Is that what you are
> thinking of?
> 

That can’t hurt, but my point is, if you can think of any other example that is substantially different from
what you have, include it, specially if it involves some different syntax somehow.

Otherwise this is fine as is.

— Daniel