linux-kernel - Re: [PATCH 15/16] drm/vkms: Allow to configure the default device creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z72jKC7lpWAsbFLm@louis-chauvet-laptop>
Date: Tue, 25 Feb 2025 12:02:00 +0100
From: Louis Chauvet <louis.chauvet@...tlin.com>
To: José Expósito <jose.exposito89@...il.com>
Cc: hamohammed.sa@...il.com, simona@...ll.ch, melissa.srw@...il.com,
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
	tzimmermann@...e.de, airlied@...il.com,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 15/16] drm/vkms: Allow to configure the default device
 creation

On 18/02/25 - 18:08, José Expósito wrote:
> Add a new module param to allow to create or not the default VKMS
> instance. Useful when combined with configfs to avoid having additional
> VKMS instances.
> 
> Signed-off-by: José Expósito <jose.exposito89@...il.com>

Reviewed-by: Louis Chauvet <louis.chauvet@...tlin.com>

> ---
>  drivers/gpu/drm/vkms/vkms_drv.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index 5bcfbcb6c0c5..b4ed19c97576 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -50,6 +50,10 @@ static bool enable_overlay;
>  module_param_named(enable_overlay, enable_overlay, bool, 0444);
>  MODULE_PARM_DESC(enable_overlay, "Enable/Disable overlay support");
>  
> +static bool create_default_dev = true;
> +module_param_named(create_default_dev, create_default_dev, bool, 0444);
> +MODULE_PARM_DESC(create_default_dev, "Create or not the default VKMS device");
> +
>  DEFINE_DRM_GEM_FOPS(vkms_driver_fops);
>  
>  static void vkms_atomic_commit_tail(struct drm_atomic_state *old_state)
> @@ -219,6 +223,9 @@ static int __init vkms_init(void)
>  	if (ret)
>  		return ret;
>  
> +	if (!create_default_dev)
> +		return 0;
> +
>  	config = vkms_config_default_create(enable_cursor, enable_writeback, enable_overlay);
>  	if (IS_ERR(config))
>  		return PTR_ERR(config);
> -- 
> 2.48.1
>