linux-kernel - [PATCH 0/6] drm: remove redundant else across drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <C8A4C8F8-1568-423E-A656-05D914D9933F@live.com>
Date: Tue, 25 Feb 2025 11:05:24 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: "airlied@...hat.com" <airlied@...hat.com>, "tzimmermann@...e.de"
	<tzimmermann@...e.de>, "jfalempe@...hat.com" <jfalempe@...hat.com>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"mripard@...nel.org" <mripard@...nel.org>, "airlied@...il.com"
	<airlied@...il.com>, "simona@...ll.ch" <simona@...ll.ch>, "kraxel@...hat.com"
	<kraxel@...hat.com>, "javierm@...hat.com" <javierm@...hat.com>
CC: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"virtualization@...ts.linux.dev" <virtualization@...ts.linux.dev>,
	"andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>
Subject: [PATCH 0/6] drm: remove redundant else across drivers

In primary_plane_helper_atomic_check of various drm drivers, a redundant
else statement is there. All these statements match this pattern:

if (foo)
	return foo;
else if (bar)
	return bar;

Which is equivalent to:

if (foo)
	return foo;

if (bar)
	return bar;

This error was observed by Andy Shevchenko [1] while reviewing the
appletbdrm driver, which has been submitted upstream.

A simple grep was used to find such errors.

Most likely a common code was copied and pasted among these drivers.
Some of them also seem to have been ported to use atomic helpers instead
of simple_display_pipe.

[1]: https://lore.kernel.org/dri-devel/Z7igVXqvRYTVFpXU@smile.fi.intel.com/

Aditya Garg (6):
  drm/ast: Remove redundant else in atomic_check
  drm/cirrus-qemu: Remove redundant else in atomic_check
  drm/offdrm: Remove redundant else in atomic_check
  drm/bochs: Remove redundant else in atomic_check
  drm/simpledrm: Remove redundant else in atomic_check
  drm/mgag200: Remove redundant else in atomic_check

 drivers/gpu/drm/ast/ast_mode.c         | 5 +++--
 drivers/gpu/drm/mgag200/mgag200_mode.c | 3 ++-
 drivers/gpu/drm/tiny/bochs.c           | 3 ++-
 drivers/gpu/drm/tiny/cirrus-qemu.c     | 6 ++++--
 drivers/gpu/drm/tiny/ofdrm.c           | 3 ++-
 drivers/gpu/drm/tiny/simpledrm.c       | 3 ++-
 6 files changed, 15 insertions(+), 8 deletions(-)

-- 
2.43.0