linux-kernel - Re: [PATCH v5 2/4] virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <vhlhes7wepjrtfo6qsnw5tmtvw6pdt2tfi4woqdejlit5ruczj@4cs2yvffhx74>
Date: Tue, 25 Feb 2025 12:28:24 +0100
From: Peter Hilber <quic_philber@...cinc.com>
To: Simon Horman <horms@...nel.org>
CC: "Michael S. Tsirkin" <mst@...hat.com>, Jason Wang <jasowang@...hat.com>,
        Trilok Soni <quic_tsoni@...cinc.com>,
        Srivatsa Vaddagiri
	<quic_svaddagi@...cinc.com>,
        Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
        Eugenio
 Pérez <eperezma@...hat.com>,
        Richard Cochran
	<richardcochran@...il.com>,
        <linux-kernel@...r.kernel.org>, <virtualization@...ts.linux.dev>,
        <netdev@...r.kernel.org>, David Woodhouse
	<dwmw2@...radead.org>,
        "Ridoux, Julien" <ridouxj@...zon.com>, Marc Zyngier
	<maz@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Daniel Lezcano
	<daniel.lezcano@...aro.org>,
        Alexandre Belloni
	<alexandre.belloni@...tlin.com>,
        Parav Pandit <parav@...dia.com>,
        "Matias
 Ezequiel Vara Larsen" <mvaralar@...hat.com>,
        Cornelia Huck
	<cohuck@...hat.com>, <virtio-dev@...ts.linux.dev>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v5 2/4] virtio_rtc: Add PTP clocks

On Mon, Feb 24, 2025 at 05:56:18PM +0000, Simon Horman wrote:
> On Wed, Feb 19, 2025 at 08:32:57PM +0100, Peter Hilber wrote:
> 
> ...
> 
> > +/**
> > + * viortc_ptp_gettimex64() - PTP clock gettimex64 op
> > + *
> 
> Hi Peter,
> 
> Tooling recognises this as a kernel doc, and complains
> that there is no documentation present for the function's
> parameters: ptp, ts, and sts.
> 
> Flagged by W=1 builds.
> 

Thanks, I will change the offending documentation to non kernel-doc. I
was not aware that these warnings are always considered a problem.

Peter

> > + * Context: Process context.
> > + */
> > +static int viortc_ptp_gettimex64(struct ptp_clock_info *ptp,
> > +				 struct timespec64 *ts,
> > +				 struct ptp_system_timestamp *sts)
> 
> ...