[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250225174752.5dbf65e2@kernel.org>
Date: Tue, 25 Feb 2025 17:47:52 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: Andrew Lunn <andrew@...n.ch>, Oleksij Rempel <o.rempel@...gutronix.de>,
"David S. Miller" <davem@...emloft.net>, Eric Dumazet
<edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Jonathan Corbet
<corbet@....net>, Donald Hunter <donald.hunter@...il.com>, Rob Herring
<robh@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>, Simon Horman
<horms@...nel.org>, Heiner Kallweit <hkallweit1@...il.com>, Russell King
<linux@...linux.org.uk>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
Dooley <conor+dt@...nel.org>, Thomas Petazzoni
<thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
linux-doc@...r.kernel.org, Kyle Swenson <kyle.swenson@....tech>, Dent
Project <dentproject@...uxfoundation.org>, kernel@...gutronix.de, Maxime
Chevallier <maxime.chevallier@...tlin.com>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5 06/12] net: pse-pd: Add support for budget
evaluation strategies
On Tue, 25 Feb 2025 10:25:58 +0100 Kory Maincent wrote:
> On Mon, 24 Feb 2025 13:45:22 -0800
> Jakub Kicinski <kuba@...nel.org> wrote:
>
> > > No they can't for now. Even different PSE power domains within the same PSE
> > > controller. I will make it explicit.
> >
> > Sounds like the property is placed at the wrong level of the hierarchy,
> > then.
>
> When a PSE controller appears to be able to support mixed budget strategy and
> could switch between them it will be better to have it set at the PSE power
> domain level. As the budget is per PSE power domain, its strategy should also
> be per PSE power domain.
> For now, it is simply not configurable and can't be mixed. It is hard-coded by
> the PSE driver.
Yes, but uAPI is forever. We will have to live with those domain
attributes duplicated on each port. Presumably these port attributes
will never support a SET operation, since the set should be towards
the domain? The uAPI does not inspire confidence. If we need more
drivers to define a common API maybe a local sysfs API in the driver
will do?
Powered by blists - more mailing lists