linux-kernel - Re: [PATCH v3 0/5] xHCI: Isochronous error handling fixes and improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8bf4212a-72af-4c5d-a9b2-f3363d3ee3cd@linux.intel.com>
Date: Wed, 26 Feb 2025 14:41:44 +0200
From: Mathias Nyman <mathias.nyman@...ux.intel.com>
To: Michal Pecio <michal.pecio@...il.com>,
 Mathias Nyman <mathias.nyman@...el.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Niklas Neronin <niklas.neronin@...ux.intel.com>,
 linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/5] xHCI: Isochronous error handling fixes and
 improvements

On 26.2.2025 9.02, Michal Pecio wrote:
> These patches reduce latency of error reporting in some cases related
> to 'error mid TD' and Missed Service events and sometimes fix a failure
> to give back such TDs altogether until they are cancelled.
> 
> Also included are fixes for potential packet loss or memory corruption
> due to obscure races. Whether it causes problems IRL is not known and
> the worst case would be hard to reproduce, but exactly for this reason
> if the worst case actually happens, it could be hard to debug too.
> 
> The first three should be safe. The fourth should also be safe, but it
> relies on HC functionality Linux never relied on before, so I placed it
> towards the end in case it would need some tweaks. I tested it on all
> hardware I have and it worked just fine.
> 
> The last one is perhaps the most controversial, though it should be
> OK with typical "complete -> resubmit" drivers. It's the only one here
> which increases latency in some severe error cases. The intent is to
> avoid potentially giving back URBs not yet executed by hardware.
> 
> New in v3:
> - dropped the cleanup patch
> - added Don't skip on Stopped - Length Invalid
> 
> New in v3:
> - fixed spurious empty list warning on xrun
> - clear skip flag if one skipped event was the last
> 
> Michal Pecio (5):
>    usb: xhci: Don't skip on Stopped - Length Invalid
>    usb: xhci: Complete 'error mid TD' transfers when handling Missed
>      Service
>    usb: xhci: Fix isochronous Ring Underrun/Overrun event handling
>    usb: xhci: Expedite skipping missed isoch TDs on modern HCs
>    usb: xhci: Skip only one TD on Ring Underrun/Overrun
> 

Updated my for-usb-next branch to this v3 version

Thanks
Mathias