linux-kernel - Re: [PATCH v1 3/4] pps: generators: tio: Introduce Intel Elkhart Lake PSE TIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z78QiXa4-Efoq-hT@smile.fi.intel.com>
Date: Wed, 26 Feb 2025 15:00:57 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Raag Jadav <raag.jadav@...el.com>
Cc: lee@...nel.org, giometti@...eenne.com, gregkh@...uxfoundation.org,
	raymond.tan@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 3/4] pps: generators: tio: Introduce Intel Elkhart
 Lake PSE TIO

On Wed, Feb 26, 2025 at 11:45:26AM +0530, Raag Jadav wrote:
> Add initial support for Intel Elkhart Lake PSE TIO controller.

...

> +static const struct pps_tio_data ehl_pse_data = {
> +	.regs = {
> +		.ctl = TIOCTL_PSE,
> +		.compv = TIOCOMPV_PSE,
> +		.ec = TIOEC_PSE,
> +	},
> +};

Same as previous comment, please move it further in the code closer to the ID
table which is the user of this data.

-- 
With Best Regards,
Andy Shevchenko