linux-kernel - Re: [PATCH v3] auxdisplay: hd44780: Fix a potential memory leak in hd44780.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z78WxDiEIaYSaQfz@smile.fi.intel.com>
Date: Wed, 26 Feb 2025 15:27:32 +0200
From: Andy Shevchenko <andy@...nel.org>
To: Haoxiang Li <haoxiang_li2024@....com>
Cc: geert@...ux-m68k.org, u.kleine-koenig@...gutronix.de,
	erick.archer@...look.com, ojeda@...nel.org, w@....eu,
	poeschel@...onage.de, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH v3] auxdisplay: hd44780: Fix a potential memory leak in
 hd44780.c

On Wed, Feb 26, 2025 at 06:12:13PM +0800, Haoxiang Li wrote:
> At the 'fail2' label in hd44780_probe(), the 'lcd' variable is
> freed via kfree(), but this does not actually release the memory
> allocated by charlcd_alloc(), as that memory is a container for lcd.
> As a result, a memory leak occurs. Replace kfree() with charlcd_free()
> to fix a potential memory leak.
> Same replacement is done in hd44780_remove().

The v2 was already applied.

-- 
With Best Regards,
Andy Shevchenko