linux-kernel - Re: [PATCH] kbuild: add dependency from vmlinux to sorttable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250226084309.0665a335@gandalf.local.home>
Date: Wed, 26 Feb 2025 08:43:09 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Xi Ruoyao <xry111@...111.site>
Cc: Masahiro Yamada <masahiroy@...nel.org>, Nathan Chancellor
 <nathan@...nel.org>, linux-kbuild@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: add dependency from vmlinux to sorttable

On Wed, 26 Feb 2025 21:30:14 +0800
Xi Ruoyao <xry111@...111.site> wrote:

> Without this dependency it's really puzzling when we bisect for a "bad"
> commit in a series of sorttable change: when "git bisect" switches to
> another commit, "make" just does nothing to vmlinux.
> 
> Signed-off-by: Xi Ruoyao <xry111@...111.site>
> ---
>  scripts/Makefile.vmlinux | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/scripts/Makefile.vmlinux b/scripts/Makefile.vmlinux
> index 873caaa55313..fb79fd6b2465 100644
> --- a/scripts/Makefile.vmlinux
> +++ b/scripts/Makefile.vmlinux
> @@ -79,6 +79,10 @@ ifdef CONFIG_DEBUG_INFO_BTF
>  vmlinux: $(RESOLVE_BTFIDS)
>  endif
>  
> +ifdef CONFIG_BUILDTIME_TABLE_SORT
> +vmlinux: scripts/sorttable
> +endif

Acked-by: Steven Rostedt (Google) <rostedt@...dmis.org>

I haven't tested this yet, but when working on the sorttable.c changes, it
definitely was an annoyance that the updates to sorttable.c didn't make any
changes without first modifying something in the kernel.

-- Steve


> +
>  # module.builtin.ranges
>  #
> ---------------------------------------------------------------------------
> ifdef CONFIG_BUILTIN_MODULE_RANGES