linux-kernel - Re: [PATCH hyperv-next v4 1/6] arm64: hyperv: Use SMCCC to detect hypervisor presence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <fe0221bb-b309-4e4b-a098-f6a246ac1f60@app.fastmail.com>
Date: Wed, 26 Feb 2025 14:57:24 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Roman Kisel" <romank@...ux.microsoft.com>
Cc: benhill@...rosoft.com, bperkins@...rosoft.com, sunilmut@...rosoft.com,
 bhelgaas@...gle.com, "Borislav Petkov" <bp@...en8.de>,
 "Catalin Marinas" <catalin.marinas@....com>,
 "Conor Dooley" <conor+dt@...nel.org>,
 "Dave Hansen" <dave.hansen@...ux.intel.com>,
 "Dexuan Cui" <decui@...rosoft.com>,
 "Haiyang Zhang" <haiyangz@...rosoft.com>,
 "H. Peter Anvin" <hpa@...or.com>, krzk+dt@...nel.org,
 Krzysztof Wilczyński <kw@...ux.com>,
 "K. Y. Srinivasan" <kys@...rosoft.com>,
 "Lorenzo Pieralisi" <lpieralisi@...nel.org>,
 "Manivannan Sadhasivam" <manivannan.sadhasivam@...aro.org>,
 "Ingo Molnar" <mingo@...hat.com>, "Rob Herring" <robh@...nel.org>,
 ssengar@...ux.microsoft.com, "Thomas Gleixner" <tglx@...utronix.de>,
 "Wei Liu" <wei.liu@...nel.org>, "Will Deacon" <will@...nel.org>,
 devicetree@...r.kernel.org, Linux-Arch <linux-arch@...r.kernel.org>,
 linux-arm-kernel@...ts.infradead.org, linux-hyperv@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH hyperv-next v4 1/6] arm64: hyperv: Use SMCCC to detect hypervisor
 presence

On Tue, Feb 25, 2025, at 23:25, Roman Kisel wrote:
> On 2/24/2025 11:24 PM, Arnd Bergmann wrote:
>> On Tue, Feb 25, 2025, at 00:22, Roman Kisel wrote:
>>> Hi Arnd,
>>
>> If you want to declare a uuid here, I think you should remove the
>> ARM_SMCCC_VENDOR_HYP_UID_HYPERV_REG_{0,1,2,3} macros and just
>> have UUID in normal UUID_INIT() notation as we do for
>> other UUIDs.
>
> I'd gladly stick to that provided I have your support of touching
> KVM's code! As the SMCCC document states, there shall be an UUID,
> and in the kernel, there would be
>
> #define ARM_SMCCC_VENDOR_KVM_UID UUID_INIT(.......)
> #define ARM_SMCCC_VENDOR_HYP_UID UUID_INIT(.......)
>
> Hence, the ARM_SMCCC_VENDOR_HYP_UID_*_REG_{0,1,2,3} can be removed as
> you're suggesting.

Yes, I think that's the best way forward, as it improves
the existing KVM code and all future functions like it.

    Arnd