linux-kernel - Re: [PATCH] riscv: remove redundant CMDLINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ed90f97a-35b4-4514-94d1-a699d673163c@ghiti.fr>
Date: Wed, 26 Feb 2025 16:16:46 +0100
From: Alexandre Ghiti <alex@...ti.fr>
To: Zixian Zeng <sycamoremoon376@...il.com>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>
Cc: linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: remove redundant CMDLINE_FORCE check

Hi Zixian,

On 13/01/2025 17:30, Zixian Zeng wrote:
> Drop redundant CMDLINE_FORCE check as it's already done in
> function early_init_dt_scan_chosen().
>
> Signed-off-by: Zixian Zeng <sycamoremoon376@...il.com>
> ---
> ---
>   arch/riscv/kernel/setup.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c
> index 45010e71df86ce40f99fabf03103a49ad1041f3d..a08a8409aab01d504d3ad975fbf9c66c02992713 100644
> --- a/arch/riscv/kernel/setup.c
> +++ b/arch/riscv/kernel/setup.c
> @@ -237,11 +237,6 @@ static void __init parse_dtb(void)
>   	} else {
>   		pr_err("No DTB passed to the kernel\n");
>   	}
> -
> -#ifdef CONFIG_CMDLINE_FORCE
> -	strscpy(boot_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
> -	pr_info("Forcing kernel command line to: %s\n", boot_command_line);
> -#endif
>   }
>   
>   #if defined(CONFIG_RISCV_COMBO_SPINLOCKS)
>
> ---
> base-commit: fa47906ff358a5865b7be2356a5a1d1e58dd17d8
> change-id: 20250113-rebund-25d469c1c4d5
>
> Best regards,


We lose the pr_info() but to me that's not a problem, so:

Reviewed-by: Alexandre Ghiti <alexghiti@...osinc.com>

Thanks,

Alex