linux-kernel - Re: [PATCH] mm: swap: fix build warning when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d372e93-599b-4072-955c-44c98eca469f@redhat.com>
Date: Wed, 26 Feb 2025 16:35:11 +0100
From: David Hildenbrand <david@...hat.com>
To: Kemeng Shi <shikemeng@...weicloud.com>, akpm@...ux-foundation.org,
 kasong@...cent.com
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: swap: fix build warning when CONFIG_SWAP is not set

On 26.02.25 19:25, Kemeng Shi wrote:
> Fix build warning that folio_alloc_swap is defined but not used when
> CONFIG_SWAP is not set.
> 
> Fixes: b79768ab943cf ("mm, swap: simplify folio swap allocation")

Not a stable commit id from upstream / mm-stable, so this should be 
squashed into the original commit.

> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
> ---
>   include/linux/swap.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/swap.h b/include/linux/swap.h
> index 3a68da686c4e..d1f5414ea537 100644
> --- a/include/linux/swap.h
> +++ b/include/linux/swap.h
> @@ -587,7 +587,7 @@ static inline int swp_swapcount(swp_entry_t entry)
>   	return 0;
>   }
>   
> -static int folio_alloc_swap(struct folio *folio, gfp_t gfp_mask)
> +static inline int folio_alloc_swap(struct folio *folio, gfp_t gfp_mask)
>   {
>   	return -EINVAL;
>   }

LGTM

-- 
Cheers,

David / dhildenb