linux-kernel - Re: [PATCH v2 0/4] Add GPIO interrupt support for Amlogic A4 and A5 SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174058387423.2466938.7799013716611230822.robh@kernel.org>
Date: Wed, 26 Feb 2025 09:36:53 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Xianwei Zhao <xianwei.zhao@...ogic.com>
Cc: Conor Dooley <conor+dt@...nel.org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Neil Armstrong <neil.armstrong@...aro.org>, devicetree@...r.kernel.org, 
 Heiner Kallweit <hkallweit1@...il.com>, Kevin Hilman <khilman@...libre.com>, 
 linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org, 
 Jerome Brunet <jbrunet@...libre.com>, linux-arm-kernel@...ts.infradead.org, 
 Thomas Gleixner <tglx@...utronix.de>, 
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Subject: Re: [PATCH v2 0/4] Add GPIO interrupt support for Amlogic A4 and
 A5 SoCs


On Wed, 26 Feb 2025 13:47:51 +0800, Xianwei Zhao wrote:
> This patch adds GPIO interrupt support for Amlogic A4 and A5 SoCs
> 
> Signed-off-by: Xianwei Zhao <xianwei.zhao@...ogic.com>
> ---
> Changes in v2:
> - Use if/then instead of direct modification minimum value for property 'amlogic,channel-interrupts'.
> - Add register offsets to the parameter structure to reduce definition of a function.
> - Link to v1: https://lore.kernel.org/r/20250219-irqchip-gpio-a4-a5-v1-0-3c8e44ae42df@amlogic.com
> 
> ---
> Xianwei Zhao (4):
>       dt-bindings: interrupt-controller: Add support for Amlogic A4 and A5 SoCs
>       irqchip: Add support for Amlogic A4 and A5 SoCs
>       arm64: dts: Add gpio_intc node for Amlogic A4 SoCs
>       arm64: dts: Add gpio_intc node for Amlogic A5 SoCs
> 
>  .../amlogic,meson-gpio-intc.yaml                   | 13 +++++++
>  arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi        | 21 +++++++++++
>  arch/arm64/boot/dts/amlogic/amlogic-a5.dtsi        | 12 +++++++
>  drivers/irqchip/irq-meson-gpio.c                   | 42 +++++++++++++++++++---
>  4 files changed, 83 insertions(+), 5 deletions(-)
> ---
> base-commit: 953913df9c3ab6f496c6facd5aa7fc9f2f847ac2
> change-id: 20241213-irqchip-gpio-a4-a5-80c50a1456c4
> 
> Best regards,
> --
> Xianwei Zhao <xianwei.zhao@...ogic.com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/amlogic/' for 20250226-irqchip-gpio-a4-a5-v2-0-c55b1050cb55@...ogic.com:

arch/arm64/boot/dts/amlogic/amlogic-a4-a113l2-ba400.dtb: interrupt-controller@...2c: amlogic,channel-interrupts: [140, 141] is too short
	from schema $id: http://devicetree.org/schemas/interrupt-controller/amlogic,meson-gpio-intc.yaml#