linux-kernel - Re: [PATCH 1/2] rust: Add cpumask helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z78-l1wBYk7nlR5i@thinkpad>
Date: Wed, 26 Feb 2025 11:17:33 -0500
From: Yury Norov <yury.norov@...il.com>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: Daniel Almeida <daniel.almeida@...labora.com>,
	Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
	Danilo Krummrich <dakr@...hat.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	Stephen Boyd <sboyd@...nel.org>, Nishanth Menon <nm@...com>,
	Manos Pitsidianakis <manos.pitsidianakis@...aro.org>,
	Erik Schilling <erik.schilling@...aro.org>,
	Alex Bennée <alex.bennee@...aro.org>,
	Joakim Bech <joakim.bech@...aro.org>, Rob Herring <robh@...nel.org>,
	Christoph Hellwig <hch@....de>, Jason Gunthorpe <jgg@...dia.com>,
	John Hubbard <jhubbard@...dia.com>, linux-pm@...r.kernel.org,
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] rust: Add cpumask helpers

On Tue, Feb 25, 2025 at 03:20:54PM +0530, Viresh Kumar wrote:
> On 25-02-25, 06:43, Daniel Almeida wrote:
> > I don’t understand what is going on here. You apparently did not provide the
> > Rust code itself.
> > 
> > Usually, when I see a “in order to prepare for …” I expect the actual patch to
> > follow in the same series.
> > 
> > Right now - and correct me if I'm wrong - it seems like you’ve essentially added
> > dead code.
> 
> Rust abstractions:
> 
> https://lore.kernel.org/all/cover.1740475625.git.viresh.kumar@linaro.org/

Yes, it's a dead code. 

Cpumasks is a library, and people sometimes submit library code separately
from their main projects, so it becomes unused for a while. GENMASK_U128()
is one recent example.

I'm not happy about it, but I understand why people do so - it's important
for them to have stable API, and their big project may take longer to get
upstreamed.

So, if nobody's strongly opposite, I will move it myself. Alternatively,
we can ask Viresh to take over the patches and move them together with
his series.

Thanks,
Yury