linux-kernel - Re: [PATCH v2 0/9] usb: storage: Mark various arrays as const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea5c2735-cfb3-4e5f-a7f9-40d4493bd05a@rowland.harvard.edu>
Date: Wed, 26 Feb 2025 12:02:02 -0500
From: Alan Stern <stern@...land.harvard.edu>
To: j.ne@...teo.net
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/9] usb: storage: Mark various arrays as const

On Wed, Feb 26, 2025 at 03:17:22PM +0100, 'Jonathan Neuschäfer via B4 Relay' via USB Mass Storage on Linux wrote:
> While reading code, I noticed that some arrays in USB mass storage
> drivers are declared static but not const, even though they are not
> modified. This patchset marks them const.
> 
> All patches were compile-tested.
> 
> Signed-off-by: Jonathan Neuschäfer <j.ne@...teo.net>
> ---
> Changes in v2:
> - Add new patches 2-9
> - Use consistent authorship information
> - Link to v1: https://lore.kernel.org/r/20250225-misc-const-v1-1-121ff3b86437@posteo.net

The patches themselves look good, but I still think you should explain 
in the patch descriptions why declaring these arrays const is worth 
doing.

Merely saying _what_ you are doing isn't good enough.  We can tell what 
a patch does just by reading it.  What we can't always tell is _why_ you 
would want to do it.  That is what needs to be explained.

The explanation doesn't have to be terribly long or detailed, but you 
should not omit it entirely.

Alan Stern