linux-kernel - Re: [PATCH v2] drm/amd/display: Fix null check for pipe_ctx->plane_state in resource_build_scaling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_NJKwmiGfcP2RwK+pZD7YXA_pbe7VtsWYoNt_nVRFO5iw@mail.gmail.com>
Date: Wed, 26 Feb 2025 14:16:33 -0500
From: Alex Deucher <alexdeucher@...il.com>
To: Alex Hung <alex.hung@....com>
Cc: Ma Ke <make24@...as.ac.cn>, dillon.varone@....com, Samson.Tam@....com, 
	chris.park@....com, aurabindo.pillai@....com, george.shen@....com, 
	gabe.teeger@....com, Yihan.Zhu@....com, Tony.Cheng@....com, 
	amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2] drm/amd/display: Fix null check for
 pipe_ctx->plane_state in resource_build_scaling_params

Applied.  Thanks!

Alex

On Wed, Feb 26, 2025 at 2:04 PM Alex Hung <alex.hung@....com> wrote:
>
> Reviewed-by: Alex Hung <alex.hung@....com>
>
> On 2/26/25 01:37, Ma Ke wrote:
> > Null pointer dereference issue could occur when pipe_ctx->plane_state
> > is null. The fix adds a check to ensure 'pipe_ctx->plane_state' is not
> > null before accessing. This prevents a null pointer dereference.
> >
> > Found by code review.
> >
> > Cc: stable@...r.kernel.org
> > Fixes: 3be5262e353b ("drm/amd/display: Rename more dc_surface stuff to plane_state")
> > Signed-off-by: Ma Ke <make24@...as.ac.cn>
> > ---
> > Changes in v2:
> > - modified the patch as suggestions.
> > ---
> >   drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
> > index 520a34a42827..a45037cb4cc0 100644
> > --- a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
> > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
> > @@ -1455,7 +1455,8 @@ bool resource_build_scaling_params(struct pipe_ctx *pipe_ctx)
> >       DC_LOGGER_INIT(pipe_ctx->stream->ctx->logger);
> >
> >       /* Invalid input */
> > -     if (!plane_state->dst_rect.width ||
> > +     if (!plane_state ||
> > +                     !plane_state->dst_rect.width ||
> >                       !plane_state->dst_rect.height ||
> >                       !plane_state->src_rect.width ||
> >                       !plane_state->src_rect.height) {
>