linux-kernel - Re: [PATCH net-next v7 1/2] net: mdio: Add RTL9300 MDIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <121f35fc-f151-4c5e-a644-87485acf2eda@alliedtelesis.co.nz>
Date: Wed, 26 Feb 2025 19:35:00 +0000
From: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>
CC: "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"tsbogend@...ha.franken.de" <tsbogend@...ha.franken.de>, "andrew@...n.ch"
	<andrew@...n.ch>, "hkallweit1@...il.com" <hkallweit1@...il.com>,
	"linux@...linux.org.uk" <linux@...linux.org.uk>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"sander@...nheule.net" <sander@...nheule.net>, "markus.stockhausen@....de"
	<markus.stockhausen@....de>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-mips@...r.kernel.org"
	<linux-mips@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v7 1/2] net: mdio: Add RTL9300 MDIO driver

Hi Maxime,

On 26/02/2025 20:45, Maxime Chevallier wrote:
> Hi Chris,
>
> On Wed, 26 Feb 2025 13:07:47 +1300
> Chris Packham <chris.packham@...iedtelesis.co.nz> wrote:
>
>> Add a driver for the MDIO controller on the RTL9300 family of Ethernet
>> switches with integrated SoC. There are 4 physical SMI interfaces on the
>> RTL9300 however access is done using the switch ports. The driver takes
>> the MDIO bus hierarchy from the DTS and uses this to configure the
>> switch ports so they are associated with the correct PHY. This mapping
>> is also used when dealing with software requests from phylib.
>>
>> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> It all mostly looks good to me, there's one typo though and as it may
> be user visible, I think it's worth fixing...
>
> [...]
>
>> +static int rtl9300_mdiobus_probe_one(struct device *dev, struct rtl9300_mdio_priv *priv,
>> +				     struct fwnode_handle *node)
>> +{
>> +	struct rtl9300_mdio_chan *chan;
>> +	struct fwnode_handle *child;
>> +	struct mii_bus *bus;
>> +	u32 mdio_bus;
>> +	int err;
>> +
>> +	err = fwnode_property_read_u32(node, "reg", &mdio_bus);
>> +	if (err)
>> +		return err;
>> +
>> +	fwnode_for_each_child_node(node, child)
>> +		if (fwnode_device_is_compatible(child, "ethernet-phy-ieee802.3-c45"))
>> +			priv->smi_bus_is_c45[mdio_bus] = true;
>> +
>> +	bus = devm_mdiobus_alloc_size(dev, sizeof(*chan));
>> +	if (!bus)
>> +		return -ENOMEM;
>> +
>> +	bus->name = "Reaktek Switch MDIO Bus";
> You probably mean Realtek ? :)

Good catch thanks. I've fixed the typo locally and I'll send out a v8 
tomorrow if there aren't any other comments.