linux-kernel - printk: selective deactivation of feature ignoring non panic cpu's messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250226031628.GB592457@tiffany>
Date: Wed, 26 Feb 2025 12:16:28 +0900
From: Donghyeok Choe <d7271.choe@...sung.com>
To: pmladek@...e.com
Cc: linux-kernel@...r.kernel.org, john.ogness@...utronix.de,
	takakura@...inux.co.jp, youngmin.nam@...sung.com, hajun.sung@...sung.com,
	seungh.jung@...sung.com, jh1012.choi@...sung.com
Subject: printk: selective deactivation of feature ignoring non panic cpu's
 messages

Hello.

In 'Commit 779dbc2e78d7', a feature was included in which the message
from non panic cpu was ignored. I understand that panic cpu's message
is the most important feature in the SW livelockup issue.

However, SOC vendor's linux kernel device driver developers
in environments where hw reliability is not guaranteed The message
from non panic cpu is also important.

In the process of performing a panic when a specific cpu is fault,
another cpu has the ability to output important err information
through interrupt. If a particular cpu has an incorrect sfr access,
the debugging device driver's ISR behavior to debug it helps you
identify the problem easily.

I can output non panic cpu's backtrace through Commit bcc954c6caba,
but this seems to be not enough for me.
I would like to print out the message of non panic cpu as it is.
Can I use early_param to selectively disable that feature?

For example, as below.
I'm sending you an inquiry instead of a patch because I need to share
more about my problem situation.
Please forgive me if I broke the mailing etiquette.

ex)

diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index fb242739aec8..3f420e8bdb2c 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2368,6 +2368,17 @@ void printk_legacy_allow_panic_sync(void)
        }
 }

+static bool __read_mostly keep_printk_all_cpu_in_panic;
+
+static int __init keep_printk_all_cpu_in_panic_setup(char *str)
+{
+       keep_printk_all_cpu_in_panic = true;
+       pr_info("printk: keep printk all cpu in panic.\n");
+
+       return 0;
+}
+early_param("keep_printk_all_cpu_in_panic", keep_printk_all_cpu_in_panic_setup);
+
 asmlinkage int vprintk_emit(int facility, int level,
                            const struct dev_printk_info *dev_info,
                            const char *fmt, va_list args)
@@ -2379,13 +2390,15 @@ asmlinkage int vprintk_emit(int facility, int level,
        if (unlikely(suppress_printk))
                return 0;

-       /*
-        * The messages on the panic CPU are the most important. If
-        * non-panic CPUs are generating any messages, they will be
-        * silently dropped.
-        */
-       if (other_cpu_in_panic() && !panic_triggering_all_cpu_backtrace)
-               return 0;
+       if (!keep_printk_all_cpu_in_panic) {
+               /*
+                * The messages on the panic CPU are the most important. If
+                * non-panic CPUs are generating any messages, they will be
+                * silently dropped.
+                */
+               if (other_cpu_in_panic() && !panic_triggering_all_cpu_backtrace)
+                       return 0;
+       }

Thank you.