linux-kernel - Re: [Patch v2 11/24] perf/x86/intel: Factor out common functions to process PEBS groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42081958-3d07-4dab-87f7-f4b0c726d24e@linux.intel.com>
Date: Wed, 26 Feb 2025 13:24:45 +0800
From: "Mi, Dapeng" <dapeng1.mi@...ux.intel.com>
To: Peter Zijlstra <peterz@...radead.org>
Cc: Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo
 <acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
 Ian Rogers <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Kan Liang <kan.liang@...ux.intel.com>, Andi Kleen <ak@...ux.intel.com>,
 Eranian Stephane <eranian@...gle.com>, linux-kernel@...r.kernel.org,
 linux-perf-users@...r.kernel.org, Dapeng Mi <dapeng1.mi@...el.com>
Subject: Re: [Patch v2 11/24] perf/x86/intel: Factor out common functions to
 process PEBS groups


On 2/25/2025 7:02 PM, Peter Zijlstra wrote:
> On Tue, Feb 18, 2025 at 03:28:05PM +0000, Dapeng Mi wrote:
>> Adaptive PEBS and arch-PEBS share lots of same code to process these
>> PEBS groups, like basic, GPR and meminfo groups. Extract these shared
>> code to common functions to avoid duplicated code.
> Should you not flip this and the previous patch? Because afaict you're
> mostly removing the code you just added, which is a bit silly.

Sure.