[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20250226063651.513178-10-sj@kernel.org>
Date: Tue, 25 Feb 2025 22:36:47 -0800
From: SeongJae Park <sj@...nel.org>
To:
Cc: SeongJae Park <sj@...nel.org>,
Andrew Morton <akpm@...ux-foundation.org>,
damon@...ts.linux.dev,
kernel-team@...a.com,
linux-kernel@...r.kernel.org,
linux-mm@...ck.org
Subject: [RFC PATCH 09/13] mm/damon: remove damon_callback->private
The field was added to let users keep their personal data to use inside
of the callbacks. However, no one is actively using that now. Remove
it.
Signed-off-by: SeongJae Park <sj@...nel.org>
---
include/linux/damon.h | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/include/linux/damon.h b/include/linux/damon.h
index 636dcdc49b22..2b783c91cbb5 100644
--- a/include/linux/damon.h
+++ b/include/linux/damon.h
@@ -604,12 +604,10 @@ struct damon_operations {
* @after_aggregation: Called after each aggregation.
* @before_damos_apply: Called before applying DAMOS action.
* @before_terminate: Called before terminating the monitoring.
- * @private: User private data.
*
* The monitoring thread (&damon_ctx.kdamond) calls @before_start and
* @before_terminate just before starting and finishing the monitoring,
- * respectively. Therefore, those are good places for installing and cleaning
- * @private.
+ * respectively.
*
* The monitoring thread calls @after_wmarks_check after each DAMON-based
* operation schemes' watermarks check. If users need to make changes to the
@@ -625,8 +623,6 @@ struct damon_operations {
* If any callback returns non-zero, monitoring stops.
*/
struct damon_callback {
- void *private;
-
int (*before_start)(struct damon_ctx *context);
int (*after_wmarks_check)(struct damon_ctx *context);
int (*after_sampling)(struct damon_ctx *context);
--
2.39.5
Powered by blists - more mailing lists