lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250226065650.GC951736@rocinante>
Date: Wed, 26 Feb 2025 15:56:50 +0900
From: Krzysztof Wilczyński <kw@...ux.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc: jingoohan1@...il.com, lpieralisi@...nel.org, robh@...nel.org,
	bhelgaas@...gle.com, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, shradha.t@...sung.com,
	cassel@...nel.org
Subject: Re: [PATCH 2/2] PCI: dwc-debugfs: Return -EOPNOTSUPP if an event
 counter is not supported

Hello,

> If the platform doesn't support an event counter, enabling it using the
> 'counter_enable' debugfs attribute currently will succeed. But reading the
> debugfs attribute back will return 'Counter Disabled'.
> 
> This could cause confusion to the users. So while enabling an event
> counter in counter_enable_write(), always read back the status to check if
> the counter is enabled or not. If not, return -EOPNOTSUPP to let the users
> know that the event counter is not supported.

Thank you for following up on this.  Appreciated.  With that...

Reviewed-by: Krzysztof Wilczyński <kwilczynski@...nel.org>

Thank you!

	Krzysztof

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ