linux-kernel - Re: [PATCH -next] scsi: ufs: rockchip: Simplify bool conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a18fb035-3e7f-443a-8b24-9a51cba5604a@rock-chips.com>
Date: Wed, 26 Feb 2025 14:49:42 +0800
From: Shawn Lin <shawn.lin@...k-chips.com>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: shawn.lin@...k-chips.com, martin.petersen@...cle.com, heiko@...ech.de,
 linux-scsi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Abaci Robot <abaci@...ux.alibaba.com>, James.Bottomley@...senPartnership.com
Subject: Re: [PATCH -next] scsi: ufs: rockchip: Simplify bool conversion

在 2025/2/26 10:11, Jiapeng Chong 写道:
> ./drivers/ufs/host/ufs-rockchip.c:268:70-75: WARNING: conversion to bool not needed here.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=19055
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

Acked-by: Shawn Lin <shawn.lin@...k-chips.com>

Thanks Jiapeng.


> ---
>   drivers/ufs/host/ufs-rockchip.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ufs/host/ufs-rockchip.c b/drivers/ufs/host/ufs-rockchip.c
> index 5b0ea9820767..350cb0f8d0c2 100644
> --- a/drivers/ufs/host/ufs-rockchip.c
> +++ b/drivers/ufs/host/ufs-rockchip.c
> @@ -265,7 +265,7 @@ static int ufs_rockchip_runtime_suspend(struct device *dev)
>   	clk_disable_unprepare(host->ref_out_clk);
>   
>   	/* Do not power down the genpd if rpm_lvl is less than level 5 */
> -	dev_pm_genpd_rpm_always_on(dev, hba->rpm_lvl < UFS_PM_LVL_5 ? true : false);
> +	dev_pm_genpd_rpm_always_on(dev, hba->rpm_lvl < UFS_PM_LVL_5);
>   
>   	return ufshcd_runtime_suspend(dev);
>   }