[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250226082512.6a06e9f7@bootlin.com>
Date: Wed, 26 Feb 2025 08:25:12 +0100
From: Herve Codina <herve.codina@...tlin.com>
To: Alexander Stein <alexander.stein@...tq-group.com>
Cc: Andrzej Hajda <andrzej.hajda@...el.com>, Neil Armstrong
<neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>, Laurent
Pinchart <Laurent.pinchart@...asonboard.com>, Jonas Karlman
<jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>, Maarten
Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
<mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, David Airlie
<airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] drm/bridge: ti-sn65dsi83: Support negative DE
polarity
Hi Alexander,
On Tue, 25 Feb 2025 14:51:13 +0100
Alexander Stein <alexander.stein@...tq-group.com> wrote:
> Polarity for DE is stored in bridge state. Use this flag for setting
> the DE polarity in the bridge.
>
> Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> ---
> drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> index 54ad462d17ef7..95563aa1b450d 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> @@ -561,6 +561,8 @@ static void sn65dsi83_atomic_pre_enable(struct drm_bridge *bridge,
> REG_LVDS_FMT_HS_NEG_POLARITY : 0) |
> (mode->flags & DRM_MODE_FLAG_NVSYNC ?
> REG_LVDS_FMT_VS_NEG_POLARITY : 0);
> + val |= bridge_state->output_bus_cfg.flags & DRM_BUS_FLAG_DE_LOW ?
> + REG_LVDS_FMT_DE_NEG_POLARITY : 0;
>
> /* Set up bits-per-pixel, 18bpp or 24bpp. */
> if (lvds_format_24bpp) {
Tested without regression on my system.
Tested-by: Herve Codina <herve.codina@...tlin.com>
Best regards,
Hervé
Powered by blists - more mailing lists