linux-kernel - Re: [PATCH 1/3] dummycon: only build module if there are users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d047af3-fd30-4fa4-aa3d-c0359856d750@suse.de>
Date: Wed, 26 Feb 2025 08:48:14 +0100
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Arnd Bergmann <arnd@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Helge Deller <deller@....de>
Cc: Arnd Bergmann <arnd@...db.de>, linux-fbdev@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] dummycon: only build module if there are users

Hi Arnd

Am 25.02.25 um 17:44 schrieb Arnd Bergmann:
> From: Arnd Bergmann <arnd@...db.de>
>
> Dummycon is used as a fallback conswitchp for vgacon and fbcon
> in the VT code, and there are no references to it if all three
> are disabled, so just leave it out of the kernel image for
> configurations without those.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/video/console/Kconfig | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
> index bc31db6ef7d2..1c4263c164ce 100644
> --- a/drivers/video/console/Kconfig
> +++ b/drivers/video/console/Kconfig
> @@ -47,8 +47,7 @@ config SGI_NEWPORT_CONSOLE
>   	  card of your Indy.  Most people say Y here.
>   
>   config DUMMY_CONSOLE
> -	bool
> -	default y
> +	def_bool VT || VGA_CONSOLE || FRAMEBUFFER_CONSOLE

What about MDA_CONSOLE and STI_CONSOLE. Don't they require this as fallback?

Best regards
Thomas

>   
>   config DUMMY_CONSOLE_COLUMNS
>   	int "Initial number of console screen columns"

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)