linux-kernel - Re: [PATCH v4 2/2] dt-bindings: iio: filter: Add lpf/hpf freq margins

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250226-sparkling-caped-saluki-b1cbad@krzk-bin>
Date: Wed, 26 Feb 2025 09:03:13 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sam Winchenbach <sam.winchenbach@...mepointer.org>
Cc: linux-kernel@...r.kernel.org, lars@...afoo.de, 
	Michael.Hennerich@...log.com, antoniu.miclaus@...log.com, jic23@...nel.org, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, linux-iio@...r.kernel.org, 
	devicetree@...r.kernel.org
Subject: Re: [PATCH v4 2/2] dt-bindings: iio: filter: Add lpf/hpf freq margins

On Tue, Feb 25, 2025 at 08:46:12AM -0500, Sam Winchenbach wrote:
> Adds two properties to add a margin when automatically finding the
> corner frequencies.
> 
> Signed-off-by: Sam Winchenbach <sam.winchenbach@...mepointer.org>
> ---
>  .../bindings/iio/filter/adi,admv8818.yaml          | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)

Bindings are before users (see DT submitting patches), so this should be
re-ordered.

> 
> diff --git a/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml b/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml
> index b77e855bd594..2acdbd8d84cb 100644
> --- a/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml
> +++ b/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml
> @@ -44,6 +44,18 @@ properties:
>    '#clock-cells':
>      const: 0
>  
> +  adi,lpf-margin-hz:
> +    description:
> +      Sets minimum low-pass corner frequency to the frequency of rf_in plus
> +      this value when in auto mode.
> +    default: 0
> +
> +  adi,hpf-margin-hz:
> +    description:
> +      Sets maximum high-pass corner frequency to the frequency of rf_in minus
> +      this value when in auto mode.

IIUC, these are two bounds - lower and upper - in relation to something
else (like rf_in frequency)? If so, make it an array (naming to be
discuss, I assume you know better what's that):

adi,filter-margin-hz:
  items:
    - description: low-pass corner frequency to the freq.....
      minimum: xxxx?
      maximum: xxxx?
      default: 0
    - description: high-pass ....
      minimum: xxxx?
      maximum: xxxx?
      default: 0

Best regards,
Krzysztof