linux-kernel - Re: [PATCH] fs: namespace: fix uninitialized variable use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250226-wohlgefallen-kennwort-f82a7c042ab6@brauner>
Date: Wed, 26 Feb 2025 09:23:11 +0100
From: Christian Brauner <brauner@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Christian Brauner <brauner@...nel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Jan Kara <jack@...e.cz>,
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>,
	Jeff Layton <jlayton@...nel.org>,
	Miklos Szeredi <mszeredi@...hat.com>,
	Josef Bacik <josef@...icpanda.com>,
	"Seth Forshee (DigitalOcean)" <sforshee@...nel.org>,
	linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	llvm@...ts.linux.dev,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Nathan Chancellor <nathan@...nel.org>
Subject: Re: [PATCH] fs: namespace: fix uninitialized variable use

On Wed, 26 Feb 2025 09:11:54 +0100, Arnd Bergmann wrote:
> clang correctly notices that the 'uflags' variable initialization
> only happens in some cases:
> 
> fs/namespace.c:4622:6: error: variable 'uflags' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
>  4622 |         if (flags & MOVE_MOUNT_F_EMPTY_PATH)    uflags = AT_EMPTY_PATH;
>       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> fs/namespace.c:4623:48: note: uninitialized use occurs here
>  4623 |         from_name = getname_maybe_null(from_pathname, uflags);
>       |                                                       ^~~~~~
> fs/namespace.c:4622:2: note: remove the 'if' if its condition is always true
>  4622 |         if (flags & MOVE_MOUNT_F_EMPTY_PATH)    uflags = AT_EMPTY_PATH;
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> [...]

Applied to the vfs-6.15.mount.namespace branch of the vfs/vfs.git tree.
Patches in the vfs-6.15.mount.namespace branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.15.mount.namespace

[1/1] fs: namespace: fix uninitialized variable use
      https://git.kernel.org/vfs/vfs/c/980512134163