linux-kernel - Re: [PATCH v2 1/6] mm: pgtable: make generic tlb_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14fefa3a-9522-4995-8e51-662e80ae1747@arm.com>
Date: Wed, 26 Feb 2025 09:30:44 +0100
From: Kevin Brodsky <kevin.brodsky@....com>
To: Qi Zheng <zhengqi.arch@...edance.com>, peterz@...radead.org,
 riel@...riel.com, vishal.moola@...il.com, david@...hat.com,
 jannh@...gle.com, hughd@...gle.com, willy@...radead.org, yuzhao@...gle.com,
 muchun.song@...ux.dev, akpm@...ux-foundation.org, will@...nel.org,
 aneesh.kumar@...nel.org, npiggin@...il.com, arnd@...db.de,
 dave.hansen@...ux.intel.com, rppt@...nel.org, alexghiti@...osinc.com
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 linux-csky@...r.kernel.org, linux-hexagon@...r.kernel.org,
 loongarch@...ts.linux.dev, linux-m68k@...ts.linux-m68k.org,
 linux-mips@...r.kernel.org, linux-openrisc@...r.kernel.org,
 linux-sh@...r.kernel.org, linux-um@...ts.infradead.org, x86@...nel.org,
 linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v2 1/6] mm: pgtable: make generic tlb_remove_table() use
 struct ptdesc

On 25/02/2025 04:45, Qi Zheng wrote:
> Now only arm will call tlb_remove_ptdesc()/tlb_remove_table() when
> CONFIG_MMU_GATHER_TABLE_FREE is disabled. In this case, the type of the
> table parameter is actually struct ptdesc * instead of struct page *.
>
> Since struct ptdesc still overlaps with struct page and has not been
> separated from it, forcing the table parameter to struct page * will not
> cause any problems at this time. But this is definitely incorrect and
> needs to be fixed. So just like the generic __tlb_remove_table(), let
> generic tlb_remove_table() use struct ptdesc by default when
> CONFIG_MMU_GATHER_TABLE_FREE is disabled.
>
> Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>

Reviewed-by: Kevin Brodsky <kevin.brodsky@....com>