linux-kernel - Re: [PATCH v2] dt-bindings: interrupt-controller: Convert nxp,lpc3220-mic.txt to yaml format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250226-khaki-wildebeest-of-action-ddec48@krzk-bin>
Date: Wed, 26 Feb 2025 09:32:18 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Leonardo Felipe Takao Hirata <leo.fthirata@...il.com>
Cc: tglx@...utronix.de, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, vz@...ia.com, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, skhan@...uxfoundation.org, 
	linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH v2] dt-bindings: interrupt-controller: Convert
 nxp,lpc3220-mic.txt to yaml format

On Tue, Feb 25, 2025 at 10:09:40PM -0300, Leonardo Felipe Takao Hirata wrote:
> +properties:
> +  compatible:
> +    enum:
> +      - nxp,lpc3220-mic
> +      - nxp,lpc3220-sic
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupt-controller: true
> +
> +  '#interrupt-cells':
> +    const: 2
> +
> +  interrupts:
> +    items:
> +      - description:
> +          IRQ number.
> +      - description: |
> +          IRQ type. Can be one of:

That's not correct. Previously you said you have here two interrupts -
SIC1 and SIC2. Now you say you have one intrerrupt "IRQ Number" and
second interrupt "IRQ type". This makes little sense - your interrupt is
not "IRQ type". Unless it is an interrupt signaling that other interrupt
has type?

Look at other bindings what are the interrupts.

> +
> +              IRQ_TYPE_EDGE_RISING = Low-to-high edge triggered,
> +              IRQ_TYPE_EDGE_FALLING = High-to-low edge triggered,
> +              IRQ_TYPE_LEVEL_HIGH = Active high level-sensitive,
> +              IRQ_TYPE_LEVEL_LOW = Active low level-sensitive.

None of these are relevant here.

Best regards,
Krzysztof