linux-kernel - Re: [PATCH v2] dt-bindings: interrupt-controller: Convert nxp,lpc3220-mic.txt to yaml format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ba7cf93-e40d-433d-bba5-c43ce8510ae9@kernel.org>
Date: Wed, 26 Feb 2025 11:14:55 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vladimir Zapolskiy <vz@...ia.com>,
 Leonardo Felipe Takao Hirata <leo.fthirata@...il.com>, tglx@...utronix.de,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 skhan@...uxfoundation.org, linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH v2] dt-bindings: interrupt-controller: Convert
 nxp,lpc3220-mic.txt to yaml format

On 26/02/2025 10:41, Vladimir Zapolskiy wrote:
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - nxp,lpc3220-mic
>> +      - nxp,lpc3220-sic
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupt-controller: true
>> +
>> +  '#interrupt-cells':
>> +    const: 2
>> +
>> +  interrupts:
>> +    items:
>> +      - description:
>> +          IRQ number.
> 
> For sake of better understanding SIC1 and SIC2 interrupt controllers
> are chained to MIC, that's why there is 'interrupts' property present,
> and here 0/1 interrupt values are for regular IRQ, 30/31 are for fast IRQ.
> 
> Also please add here
> 
>    minItems: 2
>    maxItems: 2
> 
> I believe that the 'interrupts' property can be just left without any
> given description, or just give a simple description like
> 
>    IRQ and FIQ outputs of sub interrupt controllers to the main interrupt controller
If they are obvious, e.g. maxItems: 2 would be enough, but I understand
that these are distinctive interrupts from dedicated blocks - 1 and 2 -
so they should be listed.
- description: IRQ/FIO of SIC1 (or whatever name is here better)
- description: IRQ/FIO of SIC2

Best regards,
Krzysztof