linux-kernel - Re: [PATCH v3 7/9] KVM: TDX: Handle TDG.VP.VMCALL<ReportFatalError>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f16d1df0-0948-4ac4-8487-df790c1773f3@linux.intel.com>
Date: Wed, 26 Feb 2025 18:15:00 +0800
From: Binbin Wu <binbin.wu@...ux.intel.com>
To: Xiaoyao Li <xiaoyao.li@...el.com>, pbonzini@...hat.com,
 seanjc@...gle.com, kvm@...r.kernel.org
Cc: rick.p.edgecombe@...el.com, kai.huang@...el.com, adrian.hunter@...el.com,
 reinette.chatre@...el.com, tony.lindgren@...el.com,
 isaku.yamahata@...el.com, yan.y.zhao@...el.com, chao.gao@...el.com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 7/9] KVM: TDX: Handle TDG.VP.VMCALL<ReportFatalError>



On 2/26/2025 5:36 PM, Xiaoyao Li wrote:
> On 2/22/2025 9:42 AM, Binbin Wu wrote:
>> @@ -6849,9 +6850,11 @@ Valid values for 'type' are:
>>      reset/shutdown of the VM.
>>    - KVM_SYSTEM_EVENT_SEV_TERM -- an AMD SEV guest requested termination.
>>      The guest physical address of the guest's GHCB is stored in `data[0]`.
>> - - KVM_SYSTEM_EVENT_WAKEUP -- the exiting vCPU is in a suspended state and
>> -   KVM has recognized a wakeup event. Userspace may honor this event by
>> -   marking the exiting vCPU as runnable, or deny it and call KVM_RUN again.
>
> It deletes the description of KVM_SYSTEM_EVENT_WAKEUP by mistake;

Oops, sorry for not being careful enough.

>
> (Maybe we can fix the order of the descriptions by the way, KVM_SYSTEM_EVENT_SEV_TERM gets put in front of KVM_SYSTEM_EVENT_WAKEUP and KVM_SYSTEM_EVENT_SUSPEND)
>
>> + - KVM_SYSTEM_EVENT_TDX_FATAL -- a TDX guest reported a fatal error state.
>> +   KVM doesn't do any parsing or conversion, it just dumps 16 general-purpose
>> +   registers to userspace, in ascending order of the 4-bit indices for x86-64
>> +   general-purpose registers in instruction encoding, as defined in the Intel
>> +   SDM.
>>    - KVM_SYSTEM_EVENT_SUSPEND -- the guest has requested a suspension of
>>      the VM.
>