linux-kernel - Re: [PATCH v11 3/6] media: platform: synopsys: Add support for HDMI input driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <38faac84-965f-443f-b3b5-844fc965dbad@collabora.com>
Date: Wed, 26 Feb 2025 13:19:01 +0300
From: Dmitry Osipenko <dmitry.osipenko@...labora.com>
To: Hans Verkuil <hverkuil@...all.nl>,
 Shreeya Patel <shreeya.patel@...labora.com>, Heiko Stuebner
 <heiko@...ech.de>, Mauro Carvalho Chehab <mchehab@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, jose.abreu@...opsys.com,
 nelson.costa@...opsys.com, shawn.wen@...k-chips.com,
 nicolas.dufresne@...labora.com,
 Sebastian Reichel <sebastian.reichel@...labora.com>
Cc: kernel@...labora.com, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-rockchip@...ts.infradead.org, Tim Surber <me@...surber.de>,
 Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH v11 3/6] media: platform: synopsys: Add support for HDMI
 input driver

On 2/26/25 13:16, Hans Verkuil wrote:
>> +/* vb2 queue */
>> +static const struct vb2_ops hdmirx_vb2_ops = {
>> +	.queue_setup = hdmirx_queue_setup,
>> +	.buf_queue = hdmirx_buf_queue,
>> +	.wait_prepare = vb2_ops_wait_prepare,
>> +	.wait_finish = vb2_ops_wait_finish,
> These two ops are no longer needed. New drivers must not use them. I'm
> working on removing these ops, but it's not quite there yet.
> 
> I will remove these two lines manually for this v11, but if a v12 is needed,
> then make sure you drop these two lines.

Ack. Thanks for the review!

-- 
Best regards,
Dmitry