linux-kernel - Re: [PATCH RFC 3/4] mm/page_alloc_test: Add logic to isolate a node for testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+i-1C2F-Wx6_6WT_m83uEmmsaiXRU3yNOTMJOpL8yTkEjZ7Vg@mail.gmail.com>
Date: Wed, 26 Feb 2025 11:33:33 +0100
From: Brendan Jackman <jackmanb@...gle.com>
To: Yosry Ahmed <yosry.ahmed@...ux.dev>
Cc: Brendan Higgins <brendan.higgins@...ux.dev>, David Gow <davidgow@...gle.com>, 
	Rae Moar <rmoar@...gle.com>, Andrew Morton <akpm@...ux-foundation.org>, 
	David Hildenbrand <david@...hat.com>, Oscar Salvador <osalvador@...e.de>, 
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, Vlastimil Babka <vbabka@...e.cz>, 
	Michal Hocko <mhocko@...nel.org>, linux-kselftest@...r.kernel.org, 
	kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH RFC 3/4] mm/page_alloc_test: Add logic to isolate a node
 for testing

On Tue, 25 Feb 2025 at 12:20, Brendan Jackman <jackmanb@...gle.com> wrote:
>
> On Mon, 24 Feb 2025 at 19:34, Yosry Ahmed <yosry.ahmed@...ux.dev> wrote:
> > > +#ifdef CONFIG_KUNIT
> >
> > Why not CONFIG_PAGE_ALLOC_KUNIT_TEST?
>
> VISIBLE_IF_KUNIT is paired with #ifdef CONFIG_KUNIT elsewhere (I think
> there might even be docs that do this in an example) so I just
> followed the pattern.
>
> #ifdef CONFIG_KUNIT -> things are consistent and you just don't have
> to think about this very much.
>
> #ifdef CONFIG_PAGE_ALLOC_KUNIT_TEST -> better scoping.
>
> So yeah, shrug. Maybe David/Rae/Brendan has an opinion.

Oh, actually I rescind my shrug. If we used #ifdef
CONFIG_PAGE_ALLOC_KUNIT_TEST, then -Wmissing-prototypes would fire for
people running other KUnit tests.

So yeah the function needs to be non-static exactly when there's a
prototype in the header.