linux-kernel - Re: [QUESTION] Plans for GDIX1003 Support in Goodix Touchscreen Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOm6qnmYSQz_YVaWw1c-fMm3NCVV9MoQhLQ0XGzK9o2RybLHmw@mail.gmail.com>
Date: Thu, 27 Feb 2025 19:36:12 +0800
From: Weikang Guo <guoweikang.kernel@...il.com>
To: Hans de Goede <hdegoede@...hat.com>
Cc: Bastien Nocera <hadess@...ess.net>, Dmitry Torokhov <dmitry.torokhov@...il.com>, 
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [QUESTION] Plans for GDIX1003 Support in Goodix Touchscreen Driver

Hi, Hans

On Tue, 25 Feb 2025 at 20:09, Hans de Goede <hdegoede@...hat.com> wrote:
>
> Hi WeiKang,
>
> On 25-Feb-25 3:04 AM, Weikang Guo wrote:
> > Hi Bastien, Hans, Dmitry,
> >
> > I am currently working on the Ayaneo Flip DS device, which I installed Kali
> > Linux with kernel version 6.8.11-amd. This device has two touchscreens,
> > but only one is functional. After investigating, I found that the second
> > touchscreen has the device ID GDIX1003(confirmed by exporting the results
> > through acpidump), and upon comparing with the current driver, I noticed
> > that only GDIX1001, GDIX1002, and GDX9110 are supported.
> >
> > I have also reviewed the ACPI description and can provide the details if
> > needed. Any guidance or updates on this would be greatly appreciated.
>
> I think this might just work with the existing goodix driver, just
> add the new GDIX1003 HID to the goodix_acpi_match table:
>
> diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
> index a3e8a51c9144..4b497540ed2d 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -1519,6 +1519,7 @@ MODULE_DEVICE_TABLE(i2c, goodix_ts_id);
>  static const struct acpi_device_id goodix_acpi_match[] = {
>         { "GDIX1001", 0 },
>         { "GDIX1002", 0 },
> +       { "GDIX1003", 0 },
>         { "GDX9110", 0 },
>         { }
>  };
>
> Note I'm not sure this will work, but is worth a try.
>

It works, thank you very much.

> Also please run:
>
> sudo acpidump -o acpidump.txt
>
> and send me a private (off-list) email with acpidump.txt
> attached,
>
> Regards,
>
> Hans
>

Regards

WeiKang