linux-kernel - Re: [v3 PATCH] crypto: lib/Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXHo56DhW=W=WW6cjGjYJuH-peMJaOzZGwRtD-aDPCn4VA@mail.gmail.com>
Date: Thu, 27 Feb 2025 13:04:32 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: Arnd Bergmann <arnd@...db.de>
Cc: Herbert Xu <herbert@...dor.apana.org.au>, Arnd Bergmann <arnd@...nel.org>, 
	Will Deacon <will@...nel.org>, "David S . Miller" <davem@...emloft.net>, 
	Catalin Marinas <catalin.marinas@....com>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>, 
	Harald Freudenberger <freude@...ux.ibm.com>, Holger Dengler <dengler@...ux.ibm.com>, 
	Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>, 
	Alexander Gordeev <agordeev@...ux.ibm.com>, Christian Borntraeger <borntraeger@...ux.ibm.com>, 
	Sven Schnelle <svens@...ux.ibm.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, 
	Eric Biggers <ebiggers@...gle.com>, 
	"James E . J . Bottomley" <James.Bottomley@...senpartnership.com>, Jarkko Sakkinen <jarkko@...nel.org>, 
	linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org, 
	linux-s390@...r.kernel.org
Subject: Re: [v3 PATCH] crypto: lib/Kconfig - Hide arch options from user

On Thu, 27 Feb 2025 at 12:57, Arnd Bergmann <arnd@...db.de> wrote:
>
..
>
> An unrelated issue I noticed is that CRYPTO_LIB_CHACHA20POLY1305
> depends on CRYPTO in order to pull in CRYPTO_ALGAPI, this
> looks like a mistake and could be resolved by moving
> crypto/scatterwalk.c into lib/crypto/ with its own symbol.
> That should be a separate patch of course.
>

The only use of the scatterwalk API in lib/crypto is from
chacha20poly1305_crypt_sg_inplace(), and it occurs on a cold path
where the digest buffer is covered by a separate scatterlist entry.
I'll look into whether we could just use the sg_miter API there
instead, which is what the rest of the code already uses.