linux-kernel - Re: [PATCH 7/8] arm64: Define TIF_PATCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.21.2502271308390.25291@pobox.suse.cz>
Date: Thu, 27 Feb 2025 13:10:10 +0100 (CET)
From: Miroslav Benes <mbenes@...e.cz>
To: Weinan Liu <wnliu@...gle.com>
cc: Josh Poimboeuf <jpoimboe@...nel.org>, Steven Rostedt <rostedt@...dmis.org>, 
    Indu Bhagat <indu.bhagat@...cle.com>, 
    Peter Zijlstra <peterz@...radead.org>, Mark Rutland <mark.rutland@....com>, 
    roman.gushchin@...ux.dev, Will Deacon <will@...nel.org>, 
    Ian Rogers <irogers@...gle.com>, linux-toolchains@...r.kernel.org, 
    linux-kernel@...r.kernel.org, live-patching@...r.kernel.org, 
    joe.lawrence@...hat.com, linux-arm-kernel@...ts.infradead.org, 
    "Madhavan T. Venkataraman" <madvenka@...ux.microsoft.com>, 
    Suraj Jitindar Singh <sjitindarsingh@...il.com>
Subject: Re: [PATCH 7/8] arm64: Define TIF_PATCH_PENDING for livepatch

Hi,

> diff --git a/arch/arm64/kernel/entry-common.c b/arch/arm64/kernel/entry-common.c
> index b260ddc4d3e9..b537af333b42 100644
> --- a/arch/arm64/kernel/entry-common.c
> +++ b/arch/arm64/kernel/entry-common.c
> @@ -8,6 +8,7 @@
>  #include <linux/context_tracking.h>
>  #include <linux/kasan.h>
>  #include <linux/linkage.h>
> +#include <linux/livepatch.h>
>  #include <linux/lockdep.h>
>  #include <linux/ptrace.h>
>  #include <linux/resume_user_mode.h>
> @@ -144,6 +145,9 @@ static void do_notify_resume(struct pt_regs *regs, unsigned long thread_flags)
>  				       (void __user *)NULL, current);
>  		}
>  
> +		if (thread_flags & _TIF_PATCH_PENDING)
> +			klp_update_patch_state(current);
> +
>  		if (thread_flags & (_TIF_SIGPENDING | _TIF_NOTIFY_SIGNAL))
>  			do_signal(regs);

Just a remark so that it is recorded. Once arm64 is moved to generic 
entry infra, the hunk will not be needed.

Regards,
Miroslav