linux-kernel - Re: [PATCH] rust: miscdevice: change how f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH5fLgg01C-=rQEzHLp6GZVO_a5nAFvR5qhYF81Y-CFw3hfwmA@mail.gmail.com>
Date: Thu, 27 Feb 2025 14:25:04 +0100
From: Alice Ryhl <aliceryhl@...gle.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Arnd Bergmann <arnd@...db.de>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Trevor Gross <tmgross@...ch.edu>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Christian Schrefl <chrisi.schrefl@...il.com>
Subject: Re: [PATCH] rust: miscdevice: change how f_ops vtable is constructed

On Thu, Feb 27, 2025 at 2:23 PM Alice Ryhl <aliceryhl@...gle.com> wrote:
>
> I was helping someone with writing a new Rust abstraction, and we were
> using the miscdevice abstraction as an example. While doing this, it
> became clear to me that the way I implemented the f_ops vtable is
> confusing to new Rust users, and that the approach used by the block
> abstractions is less confusing.
>
> Thus, update the miscdevice abstractions to use the same approach as
> rust/kernel/block/mq/operations.rs.
>
> Sorry about the large diff. This changes the indentation of a large
> amount of code.
>
> Reviewed-by: Christian Schrefl <chrisi.schrefl@...il.com>
> Signed-off-by: Alice Ryhl <aliceryhl@...gle.com>

I think I must have misused b4 somehow, because this lost the v2 marker ...

This is version 2, and the previous version is here:
https://lore.kernel.org/all/20250117-miscdevice-fops-change-v1-1-ec04b701c076@google.com/

The only change is rebase on v6.14-rc2.

Alice