linux-kernel - Re: [PATCH v1] arm64: dts: qcom: ipq5424: Enable MMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ryfawl6uykry5ds5kovujvepkwffdwitbqltx75wnnrqrbl4b2@i2pjwegs3u4n>
Date: Thu, 27 Feb 2025 17:03:10 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Varadarajan Narayanan <quic_varada@...cinc.com>
Cc: andersson@...nel.org, konradybcio@...nel.org, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, linux-arm-msm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] arm64: dts: qcom: ipq5424: Enable MMC

On Thu, Feb 27, 2025 at 03:12:26PM +0530, Varadarajan Narayanan wrote:
> Enable MMC and relevant pinctrl entries.
> 
> Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
> ---
>  arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> index b6e4bb3328b3..252687be9dc3 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> @@ -69,6 +69,14 @@ &qusb_phy_1 {
>  	status = "okay";
>  };
>  
> +&sdhc {
> +	pinctrl-0 = <&sdc_default_state>;

Where is it defined?

> +	pinctrl-names = "default";
> +	supports-cqe;

This property should be a part of the SoC dtsi.

> +
> +	status = "okay";
> +};
> +
>  &sleep_clk {
>  	clock-frequency = <32000>;
>  };
> -- 
> 2.34.1
> 

-- 
With best wishes
Dmitry