linux-kernel - Re: [PATCH V2 10/12] badblocks: return boolean from badblocks_set() and badblocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67c07fec6b138_b295929498@iweiny-mobl.notmuch>
Date: Thu, 27 Feb 2025 09:08:28 -0600
From: Ira Weiny <ira.weiny@...el.com>
To: Zheng Qixing <zhengqixing@...weicloud.com>, <axboe@...nel.dk>,
	<song@...nel.org>, <yukuai3@...wei.com>, <dan.j.williams@...el.com>,
	<vishal.l.verma@...el.com>, <dave.jiang@...el.com>, <ira.weiny@...el.com>,
	<dlemoal@...nel.org>, <kch@...dia.com>, <yanjun.zhu@...ux.dev>,
	<hare@...e.de>, <zhengqixing@...wei.com>, <colyli@...nel.org>,
	<geliang@...nel.org>, <xni@...hat.com>
CC: <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-raid@...r.kernel.org>, <nvdimm@...ts.linux.dev>,
	<yi.zhang@...wei.com>, <yangerkun@...wei.com>
Subject: Re: [PATCH V2 10/12] badblocks: return boolean from badblocks_set()
 and badblocks_clear()

Zheng Qixing wrote:
> From: Zheng Qixing <zhengqixing@...wei.com>
> 
> Change the return type of badblocks_set() and badblocks_clear()
> from int to bool, indicating success or failure. Specifically:
> 
> - _badblocks_set() and _badblocks_clear() functions now return
> true for success and false for failure.
> - All calls to these functions are updated to handle the new
> boolean return type.
> - This change improves code clarity and ensures a more consistent
> handling of success and failure states.
> 
> Signed-off-by: Zheng Qixing <zhengqixing@...wei.com>
> Reviewed-by: Yu Kuai <yukuai3@...wei.com>
> Acked-by: Coly Li <colyli@...nel.org>

I'm not really sure this patch adds much.  But for the nvdimm part.

Acked-by: Ira Weiny <ira.weiny@...el.com>

[snip]